Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incubator/argo-ingress] Import new chart for CloudFlare Ingress Controller #154

Closed
wants to merge 6 commits into from
Closed

[incubator/argo-ingress] Import new chart for CloudFlare Ingress Controller #154

wants to merge 6 commits into from

Conversation

osterman
Copy link
Member

@osterman osterman commented Aug 6, 2018 •
edited
Loading

what

  • Add the Argo, the cloudflare-ingress-controller (aka argo-ingress)
  • Make target update for easily updating from remote repo

why

  • Expose kubernetes services without needing to expose anything publically
  • Alternative to bitly-oauth2 proxy (which appears unmaintained and is definitely buggy!)
  • BeyondCorp-style security model'
  • Stackpoint chart is out-of-date (0.5.0); latest is 0.5.1

demo

image

references

@osterman osterman requested review from goruha and aknysh August 6, 2018 04:28
@osterman osterman self-assigned this Aug 6, 2018
@osterman
Copy link
Member Author

osterman commented Aug 6, 2018 •
edited
Loading

Wanted by cloudposse/helmfiles#17

@osterman osterman changed the title [cloudflare-ingress-controller] Import new chart [incubator/cloudflare-ingress-controller] Import new chart Aug 14, 2018
@osterman osterman changed the title [incubator/cloudflare-ingress-controller] Import new chart [incubator/argo-ingress] Import new chart for CloudFlare Ingress Controller Aug 18, 2018
@osterman
Copy link
Member Author

Rename the chart to argo-ingress since that's what the "official" one is called, despite the repo name being cloudflare-ingress-controller

@osterman osterman requested a review from goruha August 18, 2018 01:59
goruha
goruha previously requested changes Aug 18, 2018
View reviewed changes
incubator/argo-ingress/values.yaml
secret:
install: false
domain: example.co
certificate_b64: LS0tLS1CRUdJT...insert base64-encoded certificate here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be empty by default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicted on whether or not it makes sense to update. The source of the problem is upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we just clone the repo from cloudflare)

@osterman osterman requested a review from goruha September 4, 2018 20:40
@osterman osterman assigned aknysh and unassigned osterman Oct 5, 2018
@osterman
Copy link
Member Author

I think we can close this now. Cloudflare has released their own managed chart repo.

https://github.com/cloudflare/helm-charts

helm repo add cloudflare https://cloudflare.github.io/helm-charts
helm repo update

@osterman osterman closed this Oct 18, 2018
@osterman osterman deleted the chart/cloudflare-ingress-controller branch October 18, 2018 19:29
@goruha goruha restored the chart/cloudflare-ingress-controller branch October 19, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osterman @goruha @aknysh